Copilot commented on code in PR #12475:
URL: https://github.com/apache/gluten/pull/12475#discussion_r3548479915
##########
gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/clickhouse/ClickHouseTestSettings.scala:
##########
@@ -2073,6 +2074,7 @@ class ClickHouseTestSettings extends BackendTestSettings {
.excludeCH("sorting on YearMonthIntervalType(0,1) with nullable=false,
sortOrder=List('a DESC NULLS LAST)")
.excludeCH("sorting on YearMonthIntervalType(0,1) with nullable=false,
sortOrder=List('a DESC NULLS FIRST)")
enableSuite[GlutenSparkSessionExtensionSuite]
+ .includeGlutenTest("customColumnarOp")
Review Comment:
PR title/description scope is Spark 4.x Velox ("[VL]" and mentions enabling
suite in Velox UTs), but this change also updates ClickHouse test settings (and
other Spark-version settings) by filtering GlutenSparkSessionExtensionSuite to
only run the "customColumnarOp" test. Please confirm this broader scope is
intentional; otherwise consider limiting the changes to Velox-only files or
updating the PR title/description to reflect ClickHouse + Spark 3.3–4.1
coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
