felipepessoto commented on code in PR #12444: URL: https://github.com/apache/gluten/pull/12444#discussion_r3549964773
########## backends-velox/src-delta40/test/scala/org/apache/spark/sql/delta/GlutenDeltaVariantWriteSuite.scala: ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.delta + +import org.apache.spark.sql.QueryTest +import org.apache.spark.sql.Row +import org.apache.spark.sql.delta.test.DeltaSQLCommandTest +import org.apache.spark.sql.test.SharedSparkSession + +/** + * Velox has no Arrow representation for VariantType, so a Delta write that Gluten offloads to the + * native columnar writer (DataFrameWriter.save, UPDATE, ...) used to throw + * `UnsupportedOperationException: Unsupported data type: variant` at runtime. + * GlutenOptimisticTransaction now detects a schema Velox cannot write (such as one containing a + * variant) and delegates such writes to the vanilla Delta write path. These tests use offloaded + * writes (save and UPDATE) so they exercise that path; with INSERT INTO the write is not offloaded + * and would pass regardless of the fix. Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
