Copilot commented on code in PR #12485: URL: https://github.com/apache/gluten/pull/12485#discussion_r3550502783
########## ep/build-velox/src/get-velox.sh: ########## @@ -17,9 +17,9 @@ set -exu CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd) -VELOX_REPO=https://github.com/IBM/velox.git -VELOX_BRANCH=dft-2026_07_03 -VELOX_ENHANCED_BRANCH=ibm-2026_07_03 +VELOX_REPO=https://github.com/JkSelf/velox.git +VELOX_BRANCH=dft-2026_07_03-remove +VELOX_ENHANCED_BRANCH=ibm-2026_07_03-remove Review Comment: The default Velox source is switched to a personal fork (https://github.com/JkSelf/velox.git). This makes builds non-reproducible for other contributors/CI (fork can disappear or change) and contradicts the documented expectation that Gluten tracks IBM’s maintained fork of Velox (docs/get-started/Velox.md mentions ibm/velox). If this fork/branch is only needed for testing, it should be passed via --velox_repo/--velox_branch rather than becoming the default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
