zhouyuan commented on code in PR #12405:
URL: https://github.com/apache/gluten/pull/12405#discussion_r3557953032


##########
cpp/velox/compute/VeloxRuntime.h:
##########
@@ -141,9 +141,11 @@ class VeloxRuntime final : public Runtime {
       std::vector<facebook::velox::core::PlanNodeId>& scanIds,
       std::vector<facebook::velox::core::PlanNodeId>& streamIds);
 
+  // Need to make this public to be used in WholeStageResultIterator.cc
+  void registerConnectors();
+

Review Comment:
   We need to fetch session level configurations in wholestageresultiterator



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to