Copilot commented on code in PR #12497:
URL: https://github.com/apache/gluten/pull/12497#discussion_r3557978394
##########
gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -715,7 +715,9 @@ class VeloxTestSettings extends BackendTestSettings {
// TODO: 4.x enableSuite[GlutenProjectedOrderingAndPartitioningSuite] // 6
failures
enableSuite[GlutenQueryPlanningTrackerEndToEndSuite]
// TODO: 4.x enableSuite[GlutenRemoveRedundantProjectsSuite] // 14 failures
- // TODO: 4.x enableSuite[GlutenRemoveRedundantSortsSuite] // 1 failure
+ enableSuite[GlutenRemoveRedundantSortsSuite]
+ // Rewrite as it check spark SortExec.
+ .includeAllGlutenTests()
Review Comment:
The comment here is inaccurate and misleading: the suite was rewritten to
assert on Gluten's `SortExecTransformer`, not Spark's `SortExec`. Please update
the wording to match the established phrasing used elsewhere in
VeloxTestSettings (e.g. “Rewrite to match SortExecTransformer.”).
##########
gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -733,7 +733,9 @@ class VeloxTestSettings extends BackendTestSettings {
// TODO: 4.x enableSuite[GlutenProjectedOrderingAndPartitioningSuite] // 6
failures
enableSuite[GlutenQueryPlanningTrackerEndToEndSuite]
// TODO: 4.x enableSuite[GlutenRemoveRedundantProjectsSuite] // 14 failures
- // TODO: 4.x enableSuite[GlutenRemoveRedundantSortsSuite] // 1 failure
+ enableSuite[GlutenRemoveRedundantSortsSuite]
+ // Rewrite as it check spark SortExec.
+ .includeAllGlutenTests()
Review Comment:
The comment here is inaccurate and misleading: the suite was rewritten to
assert on Gluten's `SortExecTransformer`, not Spark's `SortExec`. Please update
the wording to match the established phrasing used elsewhere in
VeloxTestSettings (e.g. “Rewrite to match SortExecTransformer.”).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
