This is an automated email from the ASF dual-hosted git repository.
zml1206 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 022bc4b379 [VL] Adjust Spark 4.x inherited suite coverage (#12484)
022bc4b379 is described below
commit 022bc4b3794028e99d07960e314e531a09d0316e
Author: Mingliang Zhu <[email protected]>
AuthorDate: Mon Jul 13 08:53:28 2026 +0800
[VL] Adjust Spark 4.x inherited suite coverage (#12484)
---
.../apache/gluten/utils/velox/VeloxTestSettings.scala | 9 ++++++---
.../apache/gluten/utils/velox/VeloxTestSettings.scala | 17 ++++++++++-------
2 files changed, 16 insertions(+), 10 deletions(-)
diff --git
a/gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
b/gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
index bf2f77b623..5a3c408979 100644
---
a/gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
+++
b/gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
@@ -234,7 +234,8 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenCsvExpressionsSuite]
enableSuite[GlutenDynamicPruningSubquerySuite]
enableSuite[GlutenExprIdSuite]
- // TODO: 4.x enableSuite[GlutenExpressionEvalHelperSuite] // 2 failures
+ // GlutenExpressionEvalHelperSuite is not enabled: it validates Spark's
ExpressionEvalHelper
+ // contract, while Gluten overrides
checkEvaluation/checkExceptionInExpression.
enableSuite[GlutenExpressionImplUtilsSuite]
enableSuite[GlutenExpressionSQLBuilderSuite]
enableSuite[GlutenExpressionSetSuite]
@@ -242,9 +243,11 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenHexSuite]
enableSuite[GlutenMutableProjectionSuite]
enableSuite[GlutenNamedExpressionSuite]
- // TODO: 4.x enableSuite[GlutenObjectExpressionsSuite] // 7 failures
+ // GlutenObjectExpressionsSuite is not enabled: object/encoder interpreted
execution is
+ // JVM-side coverage and currently fails under Gluten's expression
evaluation harness.
enableSuite[GlutenOrderingSuite]
- // TODO: 4.x enableSuite[GlutenScalaUDFSuite] // 1 failure
+ // GlutenScalaUDFSuite is not enabled: ScalaUDF executes on the JVM/fallback
path, so
+ // this parent suite has limited Velox coverage value and still has one
inherited failure.
enableSuite[GlutenSchemaPruningSuite]
enableSuite[GlutenSelectedFieldSuite]
// GlutenSubExprEvaluationRuntimeSuite is removed because
SubExprEvaluationRuntimeSuite
diff --git
a/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
b/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
index e8a3006f78..6aa17584f3 100644
---
a/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
+++
b/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
@@ -218,7 +218,7 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("random")
.exclude("SPARK-9127 codegen with long seed")
enableSuite[GlutenRegexpExpressionsSuite]
- // TODO: fix on Spark-4.1 introduced by
https://github.com/apache/spark/pull/48470
+ // TODO: fix after https://github.com/facebookincubator/velox/pull/17327
.exclude("SPLIT")
enableSuite[GlutenSortShuffleSuite]
enableSuite[GlutenSortOrderExpressionsSuite]
@@ -239,11 +239,12 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenCodeGenerationSuite]
enableSuite[GlutenCodeGeneratorWithInterpretedFallbackSuite]
enableSuite[GlutenCollationExpressionSuite]
- // TODO: 4.x enableSuite[GlutenCollationRegexpExpressionsSuite] // 1 failure
+ // TODO: 4.x enableSuite[GlutenCollationRegexpExpressionsSuite] // fix
after https://github.com/facebookincubator/velox/pull/17327
enableSuite[GlutenCsvExpressionsSuite]
enableSuite[GlutenDynamicPruningSubquerySuite]
enableSuite[GlutenExprIdSuite]
- // TODO: 4.x enableSuite[GlutenExpressionEvalHelperSuite] // 2 failures
+ // GlutenExpressionEvalHelperSuite is not enabled: it validates Spark's
ExpressionEvalHelper
+ // contract, while Gluten overrides
checkEvaluation/checkExceptionInExpression.
enableSuite[GlutenExpressionImplUtilsSuite]
enableSuite[GlutenExpressionSQLBuilderSuite]
enableSuite[GlutenExpressionSetSuite]
@@ -251,9 +252,11 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenHexSuite]
enableSuite[GlutenMutableProjectionSuite]
enableSuite[GlutenNamedExpressionSuite]
- // TODO: 4.x enableSuite[GlutenObjectExpressionsSuite] // 7 failures
- // TODO: 4.x enableSuite[GlutenOrderingSuite] // 2 failures
- // TODO: 4.x enableSuite[GlutenScalaUDFSuite] // 1 failure
+ // GlutenObjectExpressionsSuite is not enabled: object/encoder interpreted
execution is
+ // JVM-side coverage and currently fails under Gluten's expression
evaluation harness.
+ enableSuite[GlutenOrderingSuite]
+ // GlutenScalaUDFSuite is not enabled: ScalaUDF executes on the JVM/fallback
path, so
+ // this parent suite has limited Velox coverage value and still has one
inherited failure.
enableSuite[GlutenSchemaPruningSuite]
enableSuite[GlutenSelectedFieldSuite]
// GlutenSubExprEvaluationRuntimeSuite is removed because
SubExprEvaluationRuntimeSuite
@@ -696,7 +699,7 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenGlobalTempViewSuite]
enableSuite[GlutenGlobalTempViewTestSuite]
enableSuite[GlutenGroupedIteratorSuite]
- // TODO: 4.x enableSuite[GlutenHiveResultSuite] // 1 failure
+ enableSuite[GlutenHiveResultSuite]
enableSuite[GlutenInsertSortForLimitAndOffsetSuite]
.exclude("root LIMIT preserves data ordering with top-K sort")
.exclude("middle LIMIT preserves data ordering with top-K sort")
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
