Copilot commented on code in PR #12493:
URL: https://github.com/apache/gluten/pull/12493#discussion_r3567712954
##########
gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -272,7 +272,9 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenDataSourceV2MetricsSuite]
enableSuite[GlutenDataSourceV2OptionSuite]
enableSuite[GlutenDataSourceV2UtilsSuite]
- // TODO: 4.x enableSuite[GlutenGroupBasedUpdateTableSuite] // 1 failure
+ enableSuite[GlutenGroupBasedUpdateTableSuite]
+ // Velox assert_not_null throws VeloxUserError instead of
SparkRuntimeException
+ .exclude("update with NOT NULL checks")
Review Comment:
`GlutenGroupBasedUpdateTableSuite` defines this case via `testGluten(...)`,
so the registered test name is prefixed with `"Gluten - "`. Using
`exclude("update with NOT NULL checks")` will only exclude the unprefixed Spark
test inherited from `GroupBasedUpdateTableSuite`, but it will NOT exclude the
new Gluten-prefixed test, so the intended exclusion won’t take effect.
##########
gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -262,7 +262,9 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenDataSourceV2MetricsSuite]
enableSuite[GlutenDataSourceV2OptionSuite]
enableSuite[GlutenDataSourceV2UtilsSuite]
- // TODO: 4.x enableSuite[GlutenGroupBasedUpdateTableSuite] // 1 failure
+ enableSuite[GlutenGroupBasedUpdateTableSuite]
+ // Velox assert_not_null throws VeloxUserError instead of
SparkRuntimeException
+ .exclude("update with NOT NULL checks")
Review Comment:
`GlutenGroupBasedUpdateTableSuite` defines this case via `testGluten(...)`,
so the registered test name is prefixed with `"Gluten - "`. Using
`exclude("update with NOT NULL checks")` will only exclude the unprefixed Spark
test inherited from `GroupBasedUpdateTableSuite`, but it will NOT exclude the
new Gluten-prefixed test, so the intended exclusion won’t take effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
