KevinyhZou commented on code in PR #12327:
URL: https://github.com/apache/gluten/pull/12327#discussion_r3575440662
##########
gluten-flink/planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecJoin.java:
##########
@@ -325,30 +324,15 @@ protected Transformation<RowData> translateToPlanInternal(
}
final RowType returnType = (RowType) getOutputType();
- final TwoInputTransformation<RowData, RowData, RowData> transform;
- if (operator instanceof GlutenTwoInputOperator) {
- transform =
- ExecNodeUtil.createTwoInputTransformation(
- leftTransform,
- rightTransform,
- createTransformationMeta(JOIN_TRANSFORMATION, config),
- new GlutenTwoInputOperatorFactory<RowData, RowData, RowData>(
- (StreamOperator<RowData>) operator),
- InternalTypeInfo.of(returnType),
- leftTransform.getParallelism(),
- 0L,
- false);
- } else {
- transform =
- ExecNodeUtil.createTwoInputTransformation(
- leftTransform,
- rightTransform,
- createTransformationMeta(JOIN_TRANSFORMATION, config),
- operator,
- InternalTypeInfo.of(returnType),
- leftTransform.getParallelism(),
- false);
- }
+ final TwoInputTransformation<RowData, RowData, RowData> transform =
Review Comment:
If `operator` is not `GlutenTwoInputOperator`, I think we should fallback to
original flink operator
##########
gluten-flink/patches/fix-velox4j.patch:
##########
@@ -15,3 +28,31 @@ index ada06f8..7ed80bb 100644
message(\"Found all shared 3rd dependencies of velox4j: \${3rd_deps}\")
foreach(dep IN LISTS 3rd_deps)
get_filename_component(link_name \${dep} NAME)
+diff --git a/src/main/cpp/main/velox4j/query/StatefulQueryExecutor.cc
b/src/main/cpp/main/velox4j/query/StatefulQueryExecutor.cc
+index 2357cf2..159e3d6 100644
+--- a/src/main/cpp/main/velox4j/query/StatefulQueryExecutor.cc
++++ b/src/main/cpp/main/velox4j/query/StatefulQueryExecutor.cc
Review Comment:
This patch should be applied to velox4j
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
