philo-he opened a new pull request, #12505:
URL: https://github.com/apache/gluten/pull/12505
<!--
Thank you for submitting a pull request! Here are some tips:
1. For first-time contributors, please read our contributing guide:
https://github.com/apache/gluten/blob/main/CONTRIBUTING.md
2. If necessary, create a GitHub issue for discussion beforehand to avoid
duplicate work.
3. If the PR is specific to a single backend, include [VL] or [CH] in the PR
title to indicate the
Velox or ClickHouse backend, respectively.
4. If the PR is not ready for review, please mark it as a draft.
-->
## What changes are proposed in this pull request?
This PR removes the two Spark 3.5 SMJ-focused CI jobs
(spark-test-spark35-smj and spark-test-spark35-slow-smj) from
velox_backend_x86.yml.
These jobs re-run the full Spark 3.5 UT suite with
spark.gluten.sql.columnar.forceShuffledHashJoin=false to exercise the
sort-merge-join path. That approach gave us broad SMJ coverage early on, and I
appreciate the intent behind it. As the test suite has grown, though, the large
majority of these tests don't actually construct a sort-merge join, so running
the entire suite a second time just to flip one join strategy adds significant
GHA usage for limited additional signal.
The SMJ path already has dedicated coverage in the jobs that remain:
- GlutenInnerJoinSuiteForceShjOff and GlutenOuterJoinSuiteForceShjOff
explicitly set forceShuffledHashJoin=false and carry no excluded tags, so they
run as part of the regular spark-test-spark35 job.
- MiscOperatorSuite includes cases that assert SortMergeJoinExecTransformer
is used (inner, left-semi, cross-with-condition) and compare results against
vanilla Spark.
If we find specific SMJ scenarios that aren't yet covered, I think the
cleaner path forward is to add targeted, purpose-built tests for those cases
rather than re-running the whole suite. That keeps CI both more effective and
more efficient.
<!--
Provide a clear and concise description of the changes introduced in this PR.
Ensure the PR description aligns with the code changes, especially after
updates.
If applicable, include "Fixes #<GitHub_Issue_ID>" to automatically close the
corresponding issue
when the PR is merged.
-->
## How was this patch tested?
N/A
<!--
Describe how the changes were tested, if applicable.
Include new tests to validate the functionality, if necessary.
For UI-related changes, attach screenshots to demonstrate the updates.
-->
## Was this patch authored or co-authored using generative AI tooling?
No.
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
