Copilot commented on code in PR #12512:
URL: https://github.com/apache/gluten/pull/12512#discussion_r3584141030
##########
gluten-ut/common/src/test/scala/org/apache/gluten/utils/BackendTestSettings.scala:
##########
@@ -42,8 +46,23 @@ abstract class BackendTestSettings {
suiteSettings
}
+ protected def disableSuite[T: ClassTag](reason: String): Unit = {
+ disableSuite(implicitly[ClassTag[T]].runtimeClass.getCanonicalName, reason)
+ }
+
+ protected def disableSuite(suiteName: String, reason: String): Unit = {
+ require(reason.nonEmpty, "Disable reason must not be empty")
+ if (enabledSuites.containsKey(suiteName)) {
Review Comment:
`disableSuite` validates `reason.nonEmpty`, but a whitespace-only reason
(e.g. " ") will still pass even though it conveys no information. Since this
API is meant to document why a suite is disabled, treat blank/whitespace as
invalid and include the suite name in the error for easier debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
