zml1206 opened a new pull request, #12530:
URL: https://github.com/apache/gluten/pull/12530
## What changes are proposed in this pull request?
Fix the following macOS linker failure when building `libvelox.dylib` with
`BUILD_TESTS=OFF`:
```text
Undefined symbols for architecture arm64:
facebook::velox::tpch::dbgen::load_dists(...)
facebook::velox::tpch::dbgen::mk_order(...)
facebook::velox::tpch::dbgen::mk_part(...)
facebook::velox::tpch::dbgen::mk_cust(...)
facebook::velox::tpch::dbgen::row_start(...)
facebook::velox::tpch::dbgen::row_stop_h(...)
ld: symbol(s) not found for architecture arm64
clang++: error: linker command failed with exit code 1
On macOS, Gluten force-loads the Velox mono archive into libvelox.dylib.
This also pulls in DBGenIterator.cpp.o, whose TPCH dbgen symbols are provided
by libdbgen.a. Previously, libdbgen.a was linked only when
BUILD_TESTS=ON.
This change also links Velox dbgen on macOS, while preserving the existing
behavior on other platforms.
```
## How was this patch tested?
Local macOS build test.
## Was this patch authored or co-authored using generative AI tooling?
ChatGPT 5.6 Sol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
