Copilot commented on code in PR #12556: URL: https://github.com/apache/gluten/pull/12556#discussion_r3610173014
########## gluten-core/src/main/scala/org/apache/gluten/execution/ColumnarToColumnarExec.scala: ########## @@ -94,4 +95,8 @@ abstract class ColumnarToColumnarExec(override val child: SparkPlan) } override def output: Seq[Attribute] = child.output + + override def outputPartitioning: Partitioning = child.outputPartitioning + + override def outputOrdering: Seq[SortOrder] = child.outputOrdering Review Comment: This changes a key physical-property contract (partitioning/ordering transparency) that affects shuffle/sort insertion. There doesn’t appear to be a unit test that fails without this change and passes with it (e.g., asserting no extra ShuffleExchange/Sort when a ColumnarToColumnarExec wrapper sits between a KeyGroupedPartitioning scan and a join, or verifying wrapper.outputPartitioning/outputOrdering == child’s). Adding a small plan-shape assertion test under gluten-ut would help prevent regressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
