jackylee-ch commented on code in PR #12557:
URL: https://github.com/apache/gluten/pull/12557#discussion_r3610292462
##########
.github/workflows/velox_backend_x86.yml:
##########
@@ -1207,10 +1207,13 @@ jobs:
path: ./cpp/build/
- name: Prepare
run: |
- dnf install -y python3.11 python3.11-pip python3.11-devel && \
- ls -la /usr/bin/python3.11 && \
- alternatives --install /usr/bin/python3 python3 /usr/bin/python3.11
1 && \
- alternatives --set python3 /usr/bin/python3.11 && \
+ # Spark 4.1 python UDF tests require Python >= 3.10, which is not
+ # packaged for CentOS 8; install it via miniconda instead.
+ curl -fsSL -o /tmp/miniconda.sh
https://repo.anaconda.com/miniconda/Miniconda3-py311_24.7.1-0-Linux-x86_64.sh
&& \
+ bash /tmp/miniconda.sh -b -p /opt/miniconda3 && \
+ ln -sf /opt/miniconda3/bin/python3.11 /usr/bin/python3 && \
+ ln -sf /opt/miniconda3/bin/pip3 /usr/bin/pip3 && \
+ python3 --version && \
pip3 install setuptools==77.0.3 && \
pip3 install pyspark==3.5.5 cython && \
pip3 install pandas==2.2.3 pyarrow==20.0.0
Review Comment:
Resolved: this revision drops the miniconda approach entirely. The Spark 4.1
jobs stay on centos-9-jdk17 with the original `dnf install python3.11` Prepare
step (unchanged from main), so there is no longer any symlink mutation of
/usr/bin/python3. The workflow file is now identical to main; the only change
in this PR is the native link step in cpp/core/CMakeLists.txt.
##########
.github/workflows/velox_backend_x86.yml:
##########
@@ -1207,10 +1207,13 @@ jobs:
path: ./cpp/build/
- name: Prepare
run: |
- dnf install -y python3.11 python3.11-pip python3.11-devel && \
- ls -la /usr/bin/python3.11 && \
- alternatives --install /usr/bin/python3 python3 /usr/bin/python3.11
1 && \
- alternatives --set python3 /usr/bin/python3.11 && \
+ # Spark 4.1 python UDF tests require Python >= 3.10, which is not
+ # packaged for CentOS 8; install it via miniconda instead.
+ curl -fsSL -o /tmp/miniconda.sh
https://repo.anaconda.com/miniconda/Miniconda3-py311_24.7.1-0-Linux-x86_64.sh
&& \
+ bash /tmp/miniconda.sh -b -p /opt/miniconda3 && \
Review Comment:
Resolved: the miniconda download is gone in this revision. The Spark 4.1
jobs stay on centos-9-jdk17 and use the same `dnf install python3.11` step as
main, so there is no longer any curl|bash of an external installer. The only
change in this PR is the native link step in cpp/core/CMakeLists.txt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
