felipepessoto commented on code in PR #12388:
URL: https://github.com/apache/gluten/pull/12388#discussion_r3617914543
##########
.github/workflows/velox_backend_x86.yml:
##########
@@ -94,6 +99,70 @@ jobs:
path: ./cpp/build/
if-no-files-found: error
+ # Delta Spark UT, run via the reusable workflow so it reuses the native lib
+ # built above instead of duplicating the native build. Not gated on
Delta-only
+ # paths: core/velox/substrait/cpp/shims changes can affect Delta query
offload,
+ # so this runs on every trigger like the other spark-test jobs.
Review Comment:
Good catch — fixed in c94aeed3e. Removed the stale comment block (it
pre-dated the gating and still said the suite "runs on every trigger"); the
`delta-changes` job keeps the accurate per-PR gating comment, and the
`delta-spark-ut` job now has a short note that it reuses the native lib and is
gated by `delta-changes` (nightly full run lives in delta_spark_ut.yml's
`schedule`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
