lgbo-ustc commented on PR #12571: URL: https://github.com/apache/gluten/pull/12571#issuecomment-5044231624
Clean-code suggestion: normalizeCompressionKind would be clearer as a static mapping table instead of a switch. For example, keep a static map from lowercase input values to the canonical native codec name, then implement normalization as trim/lowercase + map lookup, returning null when the value is absent. This makes the supported codec set explicit, avoids a long switch, and makes it harder to accidentally pass through unsupported values later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
