marin-ma commented on code in PR #12535:
URL: https://github.com/apache/gluten/pull/12535#discussion_r3638249601
##########
cpp/core/jni/JniWrapper.cc:
##########
@@ -238,45 +238,33 @@ void internalRuntimeReleaser(Runtime* runtime) {
delete runtime;
}
-class ShuffleStreamReader : public StreamReader {
- public:
- ShuffleStreamReader(JNIEnv* env, jobject reader) {
- if (env->GetJavaVM(&vm_) != JNI_OK) {
- throw GlutenException("Unable to get JavaVM instance");
- }
- ref_ = env->NewGlobalRef(reader);
- }
-
- ~ShuffleStreamReader() override {
- JNIEnv* env = nullptr;
- attachCurrentThreadAsDaemonOrThrow(vm_, &env);
- env->DeleteGlobalRef(ref_);
- }
+} // namespace
- std::shared_ptr<arrow::io::InputStream> readNextStream(arrow::MemoryPool*
pool) override {
- JNIEnv* env = nullptr;
- attachCurrentThreadAsDaemonOrThrow(vm_, &env);
+namespace gluten {
- jobject jniIn = env->CallObjectMethod(ref_, shuffleStreamReaderNextStream);
- checkException(env);
- if (jniIn == nullptr) {
- return nullptr; // No more streams to read
- }
- std::shared_ptr<arrow::io::InputStream> in =
std::make_shared<JavaInputStreamAdaptor>(env, pool, jniIn);
- return in;
+ShuffleStreamReader::ShuffleStreamReader(JNIEnv* env, jobject reader) {
Review Comment:
The implementation should be placed in `JniCommon.cc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
