Copilot commented on code in PR #12242:
URL: https://github.com/apache/gluten/pull/12242#discussion_r3656075428
##########
gluten-ut/spark35/src/test/scala/org/apache/spark/sql/GlutenBitmapExpressionsQuerySuite.scala:
##########
@@ -18,6 +18,7 @@ package org.apache.spark.sql
import org.apache.gluten.execution.HashAggregateExecBaseTransformer
+import org.apache.spark.sql.catalyst.expressions.BitmapOrAgg
Review Comment:
`BitmapOrAgg` is an aggregate expression in Spark; the import should be from
`org.apache.spark.sql.catalyst.expressions.aggregate` (current import from
`catalyst.expressions` will not compile against Spark 3.5/4.x).
##########
gluten-ut/spark40/src/test/scala/org/apache/spark/sql/GlutenBitmapExpressionsQuerySuite.scala:
##########
@@ -18,6 +18,7 @@ package org.apache.spark.sql
import org.apache.gluten.execution.HashAggregateExecBaseTransformer
+import org.apache.spark.sql.catalyst.expressions.BitmapOrAgg
Review Comment:
`BitmapOrAgg` is an aggregate expression in Spark; the import should be from
`org.apache.spark.sql.catalyst.expressions.aggregate` (current import from
`catalyst.expressions` will not compile against Spark 3.5/4.x).
##########
backends-clickhouse/src/main/scala/org/apache/gluten/utils/CHExpressionUtil.scala:
##########
@@ -200,6 +200,7 @@ object CHExpressionUtil {
REGR_INTERCEPT -> DefaultValidator(),
REGR_SXY -> DefaultValidator(),
BITMAP_CONSTRUCT_AGG -> DefaultValidator(),
+ BITMAP_OR_AGG -> DefaultValidator(),
TO_UTC_TIMESTAMP -> UtcTimestampValidator(),
Review Comment:
`BITMAP_OR_AGG` is an aggregate function (Spark class
`org.apache.spark.sql.catalyst.expressions.aggregate.BitmapOrAgg`). Putting it
in `CH_BLACKLIST_SCALAR_FUNCTION` works for `CHValidatorApi` (it checks scalar
blacklist first), but `ExpressionDocUtil.isSupport` only consults
`CH_AGGREGATE_FUNC_BLACKLIST` for aggregate expressions, so `bitmap_or_agg` may
still be reported as supported in generated CH support docs. Consider moving
this entry into `CH_AGGREGATE_FUNC_BLACKLIST` (and keeping the scalar blacklist
for actual scalar-only entries).
##########
gluten-ut/spark41/src/test/scala/org/apache/spark/sql/GlutenBitmapExpressionsQuerySuite.scala:
##########
@@ -18,6 +18,7 @@ package org.apache.spark.sql
import org.apache.gluten.execution.HashAggregateExecBaseTransformer
+import org.apache.spark.sql.catalyst.expressions.BitmapOrAgg
Review Comment:
`BitmapOrAgg` is an aggregate expression in Spark; the import should be from
`org.apache.spark.sql.catalyst.expressions.aggregate` (current import from
`catalyst.expressions` will not compile against Spark 3.5/4.x).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
