zhouyuan commented on code in PR #12420:
URL: https://github.com/apache/gluten/pull/12420#discussion_r3673395385
##########
gluten-iceberg/src/main/java/org/apache/gluten/substrait/rel/IcebergLocalFilesNode.java:
##########
@@ -118,4 +118,32 @@ protected void
processFileBuilder(ReadRel.LocalFiles.FileOrFiles.Builder fileBui
}
fileBuilder.setIceberg(icebergBuilder);
}
+
+ private static
ReadRel.LocalFiles.FileOrFiles.IcebergReadOptions.DeleteFile.Map encodeBounds(
Review Comment:
Velox's IcebergSplitReader only consumes bounds for positional deletes.
Guard with delete.content() == FileContent.POSITION_DELETES.
##########
gluten-iceberg/src/main/java/org/apache/gluten/substrait/rel/IcebergLocalFilesNode.java:
##########
@@ -118,4 +118,32 @@ protected void
processFileBuilder(ReadRel.LocalFiles.FileOrFiles.Builder fileBui
}
fileBuilder.setIceberg(icebergBuilder);
}
+
+ private static
ReadRel.LocalFiles.FileOrFiles.IcebergReadOptions.DeleteFile.Map encodeBounds(
Review Comment:
Velox's IcebergSplitReader only consumes bounds for positional deletes.
Guard with delete.content() == FileContent.POSITION_DELETES.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
