Copilot commented on code in PR #12697:
URL: https://github.com/apache/gluten/pull/12697#discussion_r3718608544
##########
gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala:
##########
@@ -570,6 +570,19 @@ object ExpressionConverter extends SQLConfHelper with
Logging {
),
r
)
+ case instr: TernaryExpression if
instr.getClass.getSimpleName.equals("RegExpInStr") =>
Review Comment:
Using getSimpleName for the class-name guard is less specific than necessary
and could mis-match if another TernaryExpression with the same simple name
appears on the classpath (or if Spark changes naming with nested/$ classes).
Since this is already a string-based match for Spark 3.3 compatibility,
consider matching on the fully qualified class name (or at least suffix) for
robustness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
