malinjawi commented on code in PR #12215:
URL: https://github.com/apache/gluten/pull/12215#discussion_r3720289562
##########
backends-velox/src-delta/main/scala/org/apache/gluten/config/VeloxDeltaConfig.scala:
##########
@@ -22,6 +22,8 @@ class VeloxDeltaConfig(conf: SQLConf) extends
GlutenCoreConfig(conf) {
import VeloxDeltaConfig._
def enableNativeWrite: Boolean = getConf(ENABLE_NATIVE_WRITE)
+
+ def enableNativeDmlRowIndexScan: Boolean =
getConf(ENABLE_NATIVE_DML_ROW_INDEX_SCAN)
Review Comment:
You're right @felipepessoto it's not the convention since accessors are
only added when some code actually calls one (like `enableNativeWrite`, used by
`OffloadDeltaCommand`).
`OffloadDeltaScan` reads the config by its key string instead, because
gluten-delta can't depend on `VeloxDeltaConfig` directly; so I removed the
unused accessor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
