infvg commented on code in PR #12699: URL: https://github.com/apache/gluten/pull/12699#discussion_r3721099681
########## gluten-iceberg/src/main/scala/org/apache/gluten/config/GlutenIcebergConfig.scala: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.gluten.config + +import org.apache.spark.sql.internal.SQLConf + +class GlutenIcebergConfig(conf: SQLConf) extends GlutenCoreConfig(conf) { + import GlutenIcebergConfig._ + + def enableNativeRead: Boolean = getConf(ENABLE_NATIVE_READ) + + def enableNativeWrite: Boolean = getConf(ENABLE_NATIVE_WRITE) +} + +/** + * Configurations of the Iceberg component. They are backend-agnostic on purpose: the read path + * ([[org.apache.gluten.extension.OffloadIcebergScan]]) is shared by all backends, and a backend + * newly supporting Iceberg write is expected to honor the same write switch rather than introduce + * its own key. + */ +object GlutenIcebergConfig extends ConfigRegistry { + + def get: GlutenIcebergConfig = { + new GlutenIcebergConfig(SQLConf.get) + } + + val ENABLE_NATIVE_READ: ConfigEntry[Boolean] = Review Comment: We could move these to GlutenConfig as opposed to making a new class ########## gluten-iceberg/src/main/scala/org/apache/gluten/config/GlutenIcebergConfig.scala: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.gluten.config + +import org.apache.spark.sql.internal.SQLConf + +class GlutenIcebergConfig(conf: SQLConf) extends GlutenCoreConfig(conf) { + import GlutenIcebergConfig._ + + def enableNativeRead: Boolean = getConf(ENABLE_NATIVE_READ) + + def enableNativeWrite: Boolean = getConf(ENABLE_NATIVE_WRITE) +} + +/** + * Configurations of the Iceberg component. They are backend-agnostic on purpose: the read path + * ([[org.apache.gluten.extension.OffloadIcebergScan]]) is shared by all backends, and a backend + * newly supporting Iceberg write is expected to honor the same write switch rather than introduce + * its own key. + */ +object GlutenIcebergConfig extends ConfigRegistry { + + def get: GlutenIcebergConfig = { + new GlutenIcebergConfig(SQLConf.get) + } + + val ENABLE_NATIVE_READ: ConfigEntry[Boolean] = Review Comment: We could move these to GlutenConfig as opposed to making a new class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
