Copilot commented on code in PR #12725:
URL: https://github.com/apache/gluten/pull/12725#discussion_r3734773629
##########
shims/spark41/src/main/scala/org/apache/gluten/sql/shims/spark41/Spark41Shims.scala:
##########
@@ -79,6 +79,8 @@ class Spark41Shims extends SparkShims {
Sig[ToPrettyString](ExpressionNames.TO_PRETTY_STRING),
Sig[RandStr](ExpressionNames.RANDSTR),
Sig[RegExpInStr](ExpressionNames.REGEXP_INSTR)
+ Sig[DayName](ExpressionNames.DAY_NAME),
Review Comment:
Missing comma between Seq elements: `Sig[RegExpInStr](...)` is no longer the
last element after adding DayName/MonthName, so this will not compile.
##########
backends-clickhouse/src/main/scala/org/apache/gluten/utils/CHExpressionUtil.scala:
##########
@@ -214,5 +214,7 @@ object CHExpressionUtil {
READ_SIDE_PADDING -> DefaultValidator(),
DIV -> DefaultValidator(),
REGEXP_INSTR -> DefaultValidator()
+ DAY_NAME -> DefaultValidator(),
Review Comment:
Missing comma between Map entries: `REGEXP_INSTR -> DefaultValidator()` is
followed by new DAY_NAME/MONTH_NAME entries, so this will not compile.
##########
shims/spark40/src/main/scala/org/apache/gluten/sql/shims/spark40/Spark40Shims.scala:
##########
@@ -80,6 +80,8 @@ class Spark40Shims extends SparkShims {
Sig[ToPrettyString](ExpressionNames.TO_PRETTY_STRING),
Sig[RandStr](ExpressionNames.RANDSTR),
Sig[RegExpInStr](ExpressionNames.REGEXP_INSTR)
+ Sig[DayName](ExpressionNames.DAY_NAME),
Review Comment:
Missing comma between Seq elements: `Sig[RegExpInStr](...)` is no longer the
last element after adding DayName/MonthName, so this will not compile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
