jackylee-ch commented on PR #12699: URL: https://github.com/apache/gluten/pull/12699#issuecomment-5238205956
I did notice that we still have several plan-level configurations, for example: * `spark.gluten.sql.columnar.appendData` * `spark.gluten.sql.columnar.replaceData` * `spark.gluten.sql.columnar.overwriteByExpression` * `spark.gluten.sql.columnar.overwritePartitionsDynamic` * `spark.gluten.sql.columnar.writeToDataSourceV2` My understanding is that these options are mainly used to control fallback for specific plans or write paths, rather than enabling or disabling a generic capability. Considering that Gluten may support more table/file formats in the future, I think these plan-level switches can still be useful as fine-grained fallback controls, especially when support varies across formats or backends. Therefore, I prefer to keep them as-is for now rather than consolidating or removing them as part of this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
