felipepessoto commented on issue #12377: URL: https://github.com/apache/gluten/issues/12377#issuecomment-5244364815
@malinjawi agreed on all of that, and #12215 sounds like the better mitigation -- taking the native materialization out of the DML path entirely beats quarantining the symptom. Noting the exact cleanup here so it isn't missed whenever the fix lands, since the quarantine is invisible unless you go looking for it. `.github/workflows/util/delta-spark-ut/flaky-error-patterns.txt` currently holds two patterns: ``` Delta RoaringBitmapArray row index \d+ exceeds max representable value Delta bitmap row index cannot be negative: -\d+ ``` Any Delta test whose failure text matches either one is treated as neutral by the gate -- never a regression, never now-passing, and dropped from the regenerated baseline. That is deliberately broad, because the bug lands on a different `*DVs*Suite` MERGE test each run. The catch is that it does not expire. If the patterns outlive the bug, a *future* regression that produces either message is silently swallowed on whichever test it hits, and CI stays green. So when this is fixed, please delete both lines in the same PR -- and note the fix will not make the gate red by itself, since a quarantined test that starts passing is ignored too. Tracked in #12743. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
