felipepessoto commented on PR #12745: URL: https://github.com/apache/gluten/pull/12745#issuecomment-5249543278
Addressed the two suppressed review comments: **"fails only ... is too absolute"** — correct, fixed in 015c5b574. The gate also exits non-zero when a run produced no usable results (no JUnit reports, a truncated `TEST-*.xml`, or fewer shards than expected), so someone debugging a red run shouldn't be hunting for a test failure that isn't there. The docs now say so. **"`!...**.md` won't match, because `**` is only a globstar as a full path segment"** — I don't think this one holds, so I've left the pattern as is. Per the [filter pattern cheat sheet](https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#filter-pattern-cheat-sheet), `**` "matches any character **including slash (`/`)**", and `'**.js'` is documented as matching `index.js`, `js/index.js` *and* `src/js/app.js` — so it isn't segment-restricted, and `**.md` matches both `README.md` in that directory and any nested Markdown. Worth noting for reviewers what this does and doesn't buy: for `pull_request`, `paths:` is evaluated against the whole PR diff rather than the latest push, so the exclusion makes a **docs-only PR** free — it doesn't stop this PR from running the suite, since this PR also changes `delta_spark_ut.yml`. That run is expected and is worth having once, given the workflow itself changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
