Copilot commented on code in PR #12690:
URL: https://github.com/apache/gluten/pull/12690#discussion_r3759595809
##########
dev/build-helper-functions.sh:
##########
@@ -234,6 +234,7 @@ function setup_linux {
if [[ "$LINUX_DISTRIBUTION" == "ubuntu" || "$LINUX_DISTRIBUTION" == "debian"
|| "$LINUX_DISTRIBUTION" == "pop" ]]; then
scripts/setup-ubuntu.sh
elif [[ "$LINUX_DISTRIBUTION" == "centos" ]]; then
+ source scripts/setup-centos-adapters.sh
case "$LINUX_VERSION_ID" in
Review Comment:
`setup_linux` sources `scripts/setup-centos-adapters.sh`, but this file
doesn't exist in this repo, and GitHub code search shows no such file in the
Velox repo (`IBM/velox`) that `get-velox.sh` clones. This will make CentOS
setup fail with "No such file or directory" before dependencies are installed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
