rui-mo commented on code in PR #12654:
URL: https://github.com/apache/gluten/pull/12654#discussion_r3765702179
##########
gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/validator/Validators.scala:
##########
@@ -282,6 +282,8 @@ object Validators {
case Minute(child, _) => containsNTZ(child.dataType)
case Second(child, _) => containsNTZ(child.dataType)
case TimestampAdd(_, _, child, _) =>
containsNTZ(child.dataType)
+ case c: Cast if c.dataType == TimestampType =>
containsNTZ(c.child.dataType)
Review Comment:
The `containsNTZ` would also allow complex types which contain TimestampNTZ
type, but those cases haven't been verified.
##########
gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/validator/Validators.scala:
##########
@@ -282,6 +282,8 @@ object Validators {
case Minute(child, _) => containsNTZ(child.dataType)
case Second(child, _) => containsNTZ(child.dataType)
case TimestampAdd(_, _, child, _) =>
containsNTZ(child.dataType)
+ case c: Cast if c.dataType == TimestampType =>
containsNTZ(c.child.dataType)
+ case c: Cast if containsNTZ(c.dataType) => c.child.dataType
== TimestampType
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
