jackylee-ch commented on code in PR #12737:
URL: https://github.com/apache/gluten/pull/12737#discussion_r3774306118
##########
dev/check-arrow-c-shading.sh:
##########
@@ -76,12 +81,29 @@ for cls in "${CLASSES[@]}"; do
fi
done
+# Second check: no org.apache.arrow.c.* class may *call* a shaded Arrow class.
+# Signatures alone miss org.apache.arrow.util.Preconditions & friends, which
are
+# invoked from constructors but never appear in a descriptor.
+mkdir -p "$WORKDIR/all"
+unzip -qo "$JAR" 'org/apache/arrow/c/*' -d "$WORKDIR/all" 2>/dev/null || true
+if compgen -G "$WORKDIR/all/org/apache/arrow/c/*.class" > /dev/null; then
+ refs=$(grep -rahoE
"org/apache/gluten/shaded/org/apache/arrow/[a-zA-Z0-9/$]+" \
Review Comment:
Fixed — regex now includes `_`/`-`.
##########
dev/check-arrow-c-shading.sh:
##########
@@ -76,12 +81,29 @@ for cls in "${CLASSES[@]}"; do
fi
done
+# Second check: no org.apache.arrow.c.* class may *call* a shaded Arrow class.
+# Signatures alone miss org.apache.arrow.util.Preconditions & friends, which
are
+# invoked from constructors but never appear in a descriptor.
+mkdir -p "$WORKDIR/all"
+unzip -qo "$JAR" 'org/apache/arrow/c/*' -d "$WORKDIR/all" 2>/dev/null || true
+if compgen -G "$WORKDIR/all/org/apache/arrow/c/*.class" > /dev/null; then
+ refs=$(grep -rahoE
"org/apache/gluten/shaded/org/apache/arrow/[a-zA-Z0-9/$]+" \
Review Comment:
Fixed — script takes prefix as arg, sourced from the pom property.
##########
gluten-arrow/pom.xml:
##########
@@ -89,13 +89,23 @@
<groupId>org.apache.arrow</groupId>
<artifactId>${arrow-memory.artifact}</artifactId>
<version>${arrow.version}</version>
- <scope>runtime</scope>
+ <scope>${arrow.deps.scope}</scope>
Review Comment:
Fixed — added arrow-memory.scope, kept runtime on 3.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
