changfan2757 opened a new pull request, #12764:
URL: https://github.com/apache/gluten/pull/12764

     Description:                                                               
                                                                                
                    
                                                                                
                                                                                
                    
     ## What changes were proposed in this pull request?                        
                                                                                
                    
                                                                                
                                                                                
                    
     Simplify `GlobalOffHeapMemoryTarget#mode` by using 
`GlutenCoreConfig.get.dynamicOffHeapSizingEnabled`                              
                                            
     instead of manually reading the config key via 
`SparkEnv.get.conf.getBoolean(...)`.                                            
                                                
                                                                                
                                                                                
                    
     ## Why are the changes needed?                                             
                                                                                
                    
                                                                                
                                                                                
                    
     `GlutenCoreConfig` already provides a type-safe accessor for this config 
with                                                                            
                      
     the default value defined in one place. Using the raw key duplicates the 
default                                                                         
                      
     value and bypasses the existing abstraction.                               
                                                                                
                    
                                                                                
                                                                                
                    
     ## Does this PR introduce any user-facing change?                          
                                                                                
                    
                                                                                
                                                                                
                    
     No.                                                                        
                                                                                
                    
                                                                                
                                                                                
                    
     ## How was this patch tested?                                              
                                                                                
                    
                                                                                
                                                                                
                    
     Existing tests. No behavior change.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to