Copilot commented on code in PR #12781:
URL: https://github.com/apache/gluten/pull/12781#discussion_r3788230561
##########
.github/workflows/delta_spark_ut.yml:
##########
@@ -139,19 +162,63 @@ env:
# Now that this is a standalone workflow (not called by velox_backend_x86.yml),
# `github.workflow` resolves to THIS workflow, so a concurrency group is both
safe
# and necessary: without it every push to a PR branch stacks another full ~2.5
h
-# Delta run instead of superseding the previous one. Keyed on the branch for
PRs
-# and the sha otherwise, matching velox_backend_x86.yml's group.
+# Delta run instead of superseding the previous one. Keyed on the PR number
when
+# there is one, so a `pull_request` run and a `/delta-test` run on the same PR
+# supersede each other -- `github.head_ref` is empty on `issue_comment`, which
+# would otherwise lump every commented-on PR into one shared group.
concurrency:
- group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
+ group: ${{ github.repository }}-${{ github.event.pull_request.number ||
github.event.issue.number || github.head_ref || github.sha }}-${{
github.workflow }}
cancel-in-progress: true
jobs:
+ # Gate + acknowledgement for `/delta-test`, and nothing else: the ref to
check
+ # out is computed in `env.DELTA_CHECKOUT_REF` above, so this job has no
outputs
+ # and the rest of the pipeline just hangs off it via `needs`.
+ #
+ # Every other event passes straight through (the `if` short-circuits),
leaving
+ # their behaviour unchanged.
+ #
+ # Kept as its own job so that `pull-requests: write` -- needed to comment
back
+ # -- is never granted to a job that builds and runs the PR's code.
+ delta-test-requested:
+ # The PR author (the whole point: a fork author cannot label their own PR,
+ # but can always comment on it) or anyone with write access. `startsWith`,
+ # not `contains`, so quoting the command while discussing it does not spend
+ # ~11 job-hours.
Review Comment:
The authorization logic below permits the PR author, or users whose
`author_association` is OWNER/MEMBER/COLLABORATOR. That is broader than “anyone
with write access” (org members/collaborators may have read-only access), so
the comment is misleading and can cause confusion about who can trigger
/delta-test.
##########
.github/workflows/util/delta-spark-ut/README.md:
##########
@@ -97,12 +97,26 @@ longer shared between them, those PRs pay for the centos-7
native build twice
filter before creating the run, so an unrelated PR costs nothing at all.
Changes to general Velox/core/native code can also affect Delta offload, but
they're touched on most PRs, so per-PR they skip the suite — the nightly run
is
- the safety net.
+ the safety net, and `/delta-test` below forces a run on any PR the filter
+ skipped.
- **Nightly** — the **full** suite runs against the latest default branch on a
`schedule` (05:00 UTC), so regressions from general Velox/core changes are
still caught daily. The nightly run enforces the baseline **and** fails on
now-passing tests (`fail_on_fixed=true`), so baseline drift surfaces as a red
nightly — the signal to refresh `known-failures.txt`.
+- **On demand, from a PR** — comment **`/delta-test`** (as the first thing in
the
+ comment) to force a full run on a PR the `paths:` filter skipped. The **PR
+ author** — including from a fork, which is why this is a comment and not a
+ label — or anyone with write access can use it. It runs the PR's merge ref
with
+ the default settings and the baseline **enforced**; `update_baseline` stays
Review Comment:
This section says “anyone with write access” can use `/delta-test`, but the
workflow gate actually allows the PR author OR `author_association` in
OWNER/MEMBER/COLLABORATOR. Since those associations are not equivalent to write
access, the README should match the actual authorization rules to avoid
misleading contributors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
