Copilot commented on code in PR #12811:
URL: https://github.com/apache/gluten/pull/12811#discussion_r3803675374
##########
gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -933,15 +933,7 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("SPARK-36120: Support cache/uncache table with TimestampNTZ type")
enableSuite[GlutenCacheTableInKryoSuite]
enableSuite[GlutenFileSourceCharVarcharTestSuite]
Review Comment:
The PR removes exclusions along with the historical context explaining the
underlying Velox Parquet-writer crash/regression. Even if the issue is fixed
now, keeping a brief comment (and ideally a link to the upstream Velox
fix/commit/issue) where the exclusions used to be will help future maintainers
quickly understand why these tests were previously disabled and what changed to
make them safe to re-enable.
##########
gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -628,8 +628,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("length check for input string values: nested in map value")
.exclude("length check for input string values: nested in both map key and
value")
Review Comment:
After removing `excludeGlutenTest(...)` for the `nested in array of struct`
case, the remaining `.exclude(...)` still makes it look like the test stays
disabled in this block. To avoid confusion for future readers, add a short
inline comment explaining that the Spark-side test is excluded because it is
overridden by Gluten suite(s), and that the Gluten override is now
intentionally re-enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
