Copilot commented on code in PR #12814:
URL: https://github.com/apache/gluten/pull/12814#discussion_r3805689625
##########
.github/workflows/velox_backend_x86.yml:
##########
@@ -103,6 +155,10 @@ jobs:
build-native-lib-centos-7:
needs: detect-changes
+ if: >-
+ needs.detect-changes.outputs.cpp == 'true' ||
+ needs.detect-changes.outputs.java == 'true' ||
+ needs.detect-changes.outputs.tools_it == 'true'
Review Comment:
This condition drops `build-native-lib-centos-7` for pure shims-only changes
(e.g. `shims35=true` with `java=false`), which can inadvertently skip any
downstream jobs that `needs: build-native-lib-centos-7` even though the
workflow comments indicate shims-only PRs should still run a subset of spark
jobs. Consider including the shims flags in this `if` (shims33/34/35/40/41) or
introducing a single aggregated output (e.g. `needs_native_lib=true`) from
`detect-changes` that covers all cases where the native artifact is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
