felipepessoto commented on PR #12778: URL: https://github.com/apache/gluten/pull/12778#issuecomment-5346516669
> @felipepessoto would you do a check if we could adopt to use multiple dev containers here? https://github.com/madebygps/multiple-dev-container-vscode @zhouyuan I checked it, and multiple configurations are supported. Alternatives can be placed under `.devcontainer/<name>/devcontainer.json`; VS Code presents a configuration picker, and Codespaces also lets users choose one when creating a codespace. Multiple configurations do not change why this PR replaces the current default. The current configuration uses the static-link vcpkg image and runs a CI packaging script during `postCreateCommand`. That script pins the build to two threads, enables static linking and all cloud-filesystem dependencies, and can block container creation for hours. The image also lacks `/opt/shims`, so the Spark unit tests cannot run there. The dynamic-link configuration is the better default for daily development because it starts quickly, includes the Spark distributions, and leaves the native build under the developer's control. For this PR, I suggest keeping the validated Velox dynamic-link configuration as the default. If a static-link alternative is needed, it should be redesigned for development rather than preserve the current configuration unchanged: - open quickly in the vcpkg image without an automatic native build; - print a manual build command with memory-aware parallelism, a selected Spark version, and optional cloud-filesystem dependencies; - use static-specific environment settings rather than copying `VELOX_BUILD_SHARED=ON` from the dynamic configuration; - either install `/opt/shims` for Spark tests or clearly identify the configuration as intended only for static packaging and reproduction. I have not evaluated ClickHouse or GPU configurations because I am not familiar enough with those backends to define and validate their environments reliably. Those configurations would need input and ownership from contributors who work on those backends. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
