Copilot commented on code in PR #12840:
URL: https://github.com/apache/gluten/pull/12840#discussion_r3822550950
##########
gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/clickhouse/ClickHouseTestSettings.scala:
##########
@@ -1038,6 +1038,7 @@ class ClickHouseTestSettings extends BackendTestSettings {
.exclude("SPARK-37742: AQE reads invalid InMemoryRelation stats and
mistakenly plans BHJ")
.exclude("SPARK-37328: skew join with 3 tables")
.exclude("SPARK-39915: Dataset.repartition(N) may not create N partitions")
+ .exclude("SPARK-37652: optimize skewed join through union")
Review Comment:
In this settings file, SPARK-37652 is excluded via `.exclude(...)` even
though the newly added coverage is introduced as a `testGluten(...)` in
`ClickHouseAdaptiveQueryExecSuite`. If the settings framework distinguishes
Spark tests vs Gluten-authored tests (as suggested by other uses of
`excludeGlutenTest`), consider using the Gluten-specific exclusion here so the
intended skip is reliably applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
