Copilot commented on code in PR #12832:
URL: https://github.com/apache/gluten/pull/12832#discussion_r3824646129
##########
gluten-substrait/src/main/resources/substrait/proto/substrait/algebra.proto:
##########
@@ -69,7 +69,11 @@ message ReadRel {
LocalFiles local_files = 6;
NamedTable named_table = 7;
ExtensionTable extension_table = 8;
- bool stream_kafka = 9;
+ IcebergTable iceberg_table = 9;
+ // Gluten addition: streaming Kafka source. Relocated from field 9 to
+ // field 1000 so the official Substrait iceberg_table can occupy its
+ // 0.98 slot.
+ bool stream_kafka = 1000;
Review Comment:
Add a descriptor-based unit test (similar to
gluten-substrait/src/test/scala/org/apache/gluten/substrait/rel/WriteRelProtoSuite.scala)
that pins the ReadRel.read_type field numbers, especially `iceberg_table = 9`
and the relocated `stream_kafka = 1000`. A round-trip through generated classes
won’t detect tag renumbers, so without a descriptor assertion this collision
could be reintroduced by a future Substrait proto rebase without failing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
