Copilot commented on code in PR #12855:
URL: https://github.com/apache/gluten/pull/12855#discussion_r3835553821
##########
.github/workflows/delta_spark_ut.yml:
##########
@@ -494,11 +498,112 @@ jobs:
--expected-shards "${{ env.DELTA_NUM_SHARDS }}" \
--known-failures
.github/workflows/util/delta-spark-ut/known-failures.txt \
--flaky-tests
.github/workflows/util/delta-spark-ut/flaky-tests.txt \
- --baseline-out aggregated/known-failures.txt
+ --baseline-out aggregated/known-failures.txt \
+ --pruned-baseline-out aggregated/pruned-known-failures.txt
Review Comment:
The scheduled workflow may still open/update the baseline PR even when the
run has global regressions: `delta-spark-aggregate` does not fail on
regressions by default, so `delta-spark-update-baseline` can run as long as
aggregation succeeds. This can create a baseline-update PR that will be
red/unmergeable due to the regressions, adding noise. Pass
`--fail-on-regression true` (or otherwise gate the update job on a
regression-free run) so the PR automation only runs on clean nightlies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
