LuciferYang commented on code in PR #12840: URL: https://github.com/apache/gluten/pull/12840#discussion_r3836014393
########## gluten-ut/spark34/src/test/scala/org/apache/spark/sql/GlutenImplicitsTest.scala: ########## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql + +import org.apache.gluten.config.GlutenConfig + +import org.apache.spark.SparkConf +import org.apache.spark.sql.execution.GlutenImplicits._ +import org.apache.spark.sql.internal.SQLConf + +class GlutenImplicitsTest extends GlutenSQLTestsBaseTrait { Review Comment: Done in this PR. `GlutenImplicitsTest` is now a single copy in `gluten-ut/test` on `GlutenQueryTest with SharedSparkSession`, spark33's copy is gone, every `enableSuite[GlutenImplicitsTest]` registration is removed, and the diff is about 500 lines smaller. The two things I said the suite would have to express are in it: `assume(BackendTestUtils.isVeloxBackendLoaded())` for the three cases where ClickHouse reports different node counts, following `GlutenCheckOverflowTransformerSuite`, and `isSparkVersionGE("3.4")` for the one expectation that differs by version. Session conf comes from `GlutenSQLTestsBaseTrait.nativeSparkConf` rather than a hand-written copy. The PR description is reworded, since this is no longer a pure addition. Separately, a few of the patterns Copilot keeps flagging are copied verbatim from spark33 rather than introduced here, so I filed them as #12856 through #12863 instead of widening this diff. CI is green. Could you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
