malinjawi commented on PR #12040:
URL: https://github.com/apache/gluten/pull/12040#issuecomment-5385696000
> @malinjawi, I noticed that a few files added in this PR carry the
`Copyright (c) Facebook, Inc. and its affiliates.` header. Does this source
code originate from Velox itself, or perhaps from the Velox fork branch but not
actually belonging to the Velox project?
Thanks @philo-he for catching this.
It's your second guess: the code doesn't belong to the Velox project. I
originally wrote it on a Velox fork branch under
`velox/connectors/hive/delta/`, where Velox's file template carries the
Copyright (c) Facebook, Inc. and its affiliates. header. When I ported it into
Gluten the ASF header was prepended on top instead of replacing that block, so
both ended up stacked. It was never merged into `facebookincubator/velox`, so
the Meta copyright doesn't apply here.
I'll send a minor PR removing the stray block from the 15 affected files
under `cpp/velox/compute/delta/ `(13 from this PR, plus
RoaringBitmapArray.{h,cpp} from #12001), leaving the ASF header only — which is
what the Delta files added in the later PRs already use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
