Copilot commented on code in PR #12870:
URL: https://github.com/apache/gluten/pull/12870#discussion_r3841637268
##########
dev/build-helper-functions.sh:
##########
@@ -253,6 +254,7 @@ function setup_linux {
elif [[ "$LINUX_DISTRIBUTION" == "openEuler" ]]; then
case "$LINUX_VERSION_ID" in
24.03)
+ source $GLUTEN_VELOX_SCRIPT_HOME/setup-openeuler24.sh
$GLUTEN_VELOX_SCRIPT_HOME/setup-openeuler24.sh ;;
Review Comment:
Quote the Velox setup script path when sourcing/executing it to avoid
word-splitting issues if the repo path ever contains spaces (and to match
typical bash safety conventions).
##########
ep/build-velox/src/setup-openeuler24.sh:
##########
@@ -231,6 +231,34 @@ function install_velox_deps {
run_and_time install_geos
}
+function install_s3 {
+ install_aws_deps
+ local MINIO_OS="linux"
+ install_minio ${MINIO_OS}
+}
Review Comment:
Quote the argument when calling install_minio to avoid
word-splitting/globbing if the value ever changes (and to keep argument-passing
consistent with bash best practices).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
