zhouyuan commented on code in PR #12663:
URL: https://github.com/apache/gluten/pull/12663#discussion_r3843764158
##########
.github/workflows/velox_backend_cache.yml:
##########
@@ -38,28 +38,29 @@ jobs:
uses: actions/cache/restore@v3
with:
path: '${{ env.CCACHE_DIR }}'
- key: ccache-centos7-release-default-${{github.sha}}
+ key: ccache-centos8-release-default-${{github.sha}}
restore-keys: |
- ccache-centos7-release-default
+ ccache-centos8-release-default
- name: Build Gluten native libraries
run: |
- docker run -v $GITHUB_WORKSPACE:/work -w /work
apache/gluten:vcpkg-centos-7-gcc13 bash -c "
+ docker run -v $GITHUB_WORKSPACE:/work -w /work
apache/gluten:vcpkg-almalinux-8-gcc13 bash -c "
+ yum install bison -y
export CCACHE_DIR=/work/.ccache
export CCACHE_MAXSIZE=1G
mkdir -p /work/.ccache
- bash dev/ci-velox-buildstatic-centos-7.sh
+ bash dev/ci-velox-buildstatic-centos-8.sh
"
- name: Save Ccache
uses: actions/cache/save@v3
id: ccache
with:
path: '${{ env.CCACHE_DIR }}'
- key: ccache-centos7-release-default-${{github.sha}}
+ key: ccache-centos8-release-default-${{github.sha}}
Review Comment:
duplicated key name with L79
##########
.github/workflows/build_bundle_package.yml:
##########
@@ -50,16 +50,17 @@ jobs:
uses: actions/cache/restore@v3
with:
path: '${{ env.CCACHE_DIR }}'
- key: ccache-centos7-release-default-${{github.sha}}
+ key: ccache-centos8-release-default-${{github.sha}}
restore-keys: |
- ccache-centos7-release-default
+ ccache-centos8-release-default
- name: Build Gluten velox third party
run: |
- docker run -v $GITHUB_WORKSPACE:/work -w /work
apache/gluten:vcpkg-centos-7-gcc13 bash -c "
+ docker run -v $GITHUB_WORKSPACE:/work -w /work
apache/gluten:vcpkg-almalinux-8-gcc13 bash -c "
Review Comment:
Initially there is a Glibc issue when running the centos7 container on GHA,
so we switch to run the script inside container instead. Since we have
upgraded, could we use the container setting of GHA now?
https://github.com/apache/gluten/blob/main/.github/workflows/velox_backend_x86.yml#L250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
