Copilot commented on code in PR #12884: URL: https://github.com/apache/gluten/pull/12884#discussion_r3847842951
########## ep/build-velox/src/get-velox.sh: ########## @@ -17,9 +17,9 @@ set -exu CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd) -VELOX_REPO=https://github.com/IBM/velox.git -VELOX_BRANCH=dft-2026_08_21 -VELOX_ENHANCED_BRANCH=ibm-2026_08_21 +VELOX_REPO=https://github.com/rui-mo/velox-dev.git +VELOX_BRANCH=test +VELOX_ENHANCED_BRANCH=test Review Comment: The default Velox checkout in this build script now points to a personal fork and a generic `test` branch. This makes builds non-reproducible and will likely break CI or downstream developer workflows; the default should remain a stable, project-owned Velox repo/branch (users can still override via `--velox_repo/--velox_branch` when testing a PR). ########## gluten-delta/src/main/scala/org/apache/gluten/execution/DeltaScanTransformer.scala: ########## @@ -146,6 +153,16 @@ case class DeltaScanTransformer( } } + private def deltaColumnMappingMode: Option[ColumnMappingMode] = relation.fileFormat match { + case d: DeltaParquetFileFormat => + d.columnMappingMode match { + case NoMapping => Some(ColumnMappingMode.NAME) + case NameMapping => Some(ColumnMappingMode.NAME) + case _ => None + } Review Comment: `deltaColumnMappingMode` does not handle Delta `IdMapping` (see `DeltaSuite` coverage for "column mapping mode = id"). With the new per-split column-mapping propagation, leaving `IdMapping` as `None` can cause the native reader to pick an unintended default mapping mode and silently read wrong columns after schema evolution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
