Copilot commented on code in PR #12893:
URL: https://github.com/apache/gluten/pull/12893#discussion_r3851846847
##########
tools/gluten-it/pom.xml:
##########
@@ -333,8 +333,8 @@
<spark.version>4.1.1</spark.version>
Review Comment:
This profile targets Spark 4.1.1, but the POM-level `java.version` remains
`1.8` (and there’s no override shown in this profile). Spark 4.x artifacts are
typically built requiring a newer Java runtime/toolchain; leaving
`java.version` at 1.8 can cause build/runtime incompatibilities when users
activate this profile. Consider overriding `java.version` (and compiler
release/source/target as appropriate) within the Spark 4.1 profile to a
compatible Java level.
##########
tools/gluten-it/pom.xml:
##########
@@ -32,12 +32,12 @@
<java.version>1.8</java.version>
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
- <scala.version>2.12.17</scala.version>
+ <scala.version>2.12.18</scala.version>
<scala.binary.version>2.12</scala.binary.version>
- <spark.version>3.5.7</spark.version>
+ <spark.version>3.5.5</spark.version>
Review Comment:
The PR description says this syncs recent version changes, but
`spark.version` is being downgraded from `3.5.7` to `3.5.5`. If this is
intentional (e.g., compatibility pin), consider calling it out in the PR
description or a short comment in the POM; otherwise, keep the newer `3.5.7` to
match the stated goal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
