LuciferYang commented on issue #12863: URL: https://github.com/apache/gluten/issues/12863#issuecomment-5410685235
Correcting one paragraph of the conclusion above, the one about `.sql` files. It said nine files appear only in `gluten-ut/spark33`'s `SUPPORTED_SQL_QUERY_LIST` and would stop running when the module is removed. They would not: they already run on `gluten-ut/spark34`. The reason is #12897. spark34 matches the supported list with `contains` while 3.5+ match with `==`, so spark34's short entries (`count.sql`, `cross-join.sql`, `having.sql`, `inner-join.sql`, `join-empty-relation.sql`, `natural-join.sql`, `outer-join.sql`, `datetime-special.sql`, `parse-schema-string.sql`) already enable those files there, under names like `udf/udf-count.sql - Scala UDF` that never appear in the list. I ran `GlutenSQLQueryTestSuite` against Spark 3.4.4 with Velox twice, with and without the nine entries added: both runs give 222 tests, 222 succeeded, 0 failed, 84 ignored, and both include the nine. So the addition was a no-op on 3.4 and there is no gap on this axis. That makes the method the mistake, not just the number: comparing the lists as sets is only valid between modules that match the same way, and spark34 does not. Filed as #12897. The rest of the conclusion stands. #12890 continues as a coverage extension for 3.5, 4.0 and 4.1, where those nine files genuinely do not run, and it is not a prerequisite for removing the module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
