Copilot commented on code in PR #12890:
URL: https://github.com/apache/gluten/pull/12890#discussion_r3853162825
##########
gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxSQLQueryTestSettings.scala:
##########
@@ -209,6 +209,15 @@ object VeloxSQLQueryTestSettings extends
SQLQueryTestSettings {
"udf/udf-pivot.sql - Scala UDF",
"udf/udf-inline-table.sql - Scala UDF",
"udf/postgreSQL/udf-select_having.sql - Scala UDF",
+ "ansi/datetime-special.sql",
+ "ansi/parse-schema-string.sql",
Review Comment:
This PR title/description says these nine Spark-3.3-only SQL query tests
should run on Spark 3.4+, but the Spark 3.4 module still doesn’t include these
entries in its supported list
(gluten-ut/spark34/.../VeloxSQLQueryTestSettings.scala). With the current
changes, the tests will run on Spark 3.5/4.0/4.1 but not on Spark 3.4, so
coverage on 3.4 remains missing unless spark34 is updated too (or the PR scope
is clarified).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
