infvg commented on code in PR #12900:
URL: https://github.com/apache/gluten/pull/12900#discussion_r3863554824
##########
gluten-iceberg/src/main/scala/org/apache/gluten/execution/IcebergScanTransformer.scala:
##########
@@ -70,10 +71,10 @@ case class IcebergScanTransformer(
GlutenIcebergSourceUtil.getInitialDefaults(scan)
private lazy val icebergFieldIds =
- if (icebergInitialDefaults.isEmpty) {
- new JHashMap[String, Integer]()
- } else {
+ if (BackendsApiManager.getSettings.supportIcebergFieldIdRead()) {
GlutenIcebergSourceUtil.getFieldIds(scan)
+ } else {
+ new JArrayList[IcebergFieldId]()
}
Review Comment:
Fixed
##########
gluten-substrait/src/main/scala/org/apache/gluten/backendsapi/TransformerApi.scala:
##########
@@ -74,11 +75,11 @@ trait TransformerApi {
def packPBMessage(message: Message): Any
- /** Packs Iceberg column initial defaults into a backend-specific read
extension. */
+ /** Packs Iceberg field identities and initial defaults into a
backend-specific read extension. */
def packIcebergReadExtension(
- fieldIds: util.Map[String, Integer],
+ fieldIds: util.List[IcebergFieldId],
initialDefaults: util.Map[String, String]): Any = {
- throw new UnsupportedOperationException("Iceberg initial-default reads are
not supported")
+ throw new UnsupportedOperationException("Iceberg field-ID reads are not
supported")
}
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
