Copilot commented on code in PR #12902: URL: https://github.com/apache/gluten/pull/12902#discussion_r3868351303
########## docs/developers/MicroBenchmarks.md: ########## @@ -36,7 +36,7 @@ generate example input files: cd /path/to/gluten/ ./dev/buildbundle-veloxbe.sh --build_tests=ON --build_benchmarks=ON -# Run test to generate input data files. If you are using spark 3.3, replace -Pspark-3.5 with -Pspark-3.3. +# Run test to generate input data files. If you are using spark 3.4, replace -Pspark-3.5 with -Pspark-3.4. mvn test -Pspark-3.5 -Pbackends-velox -pl backends-velox -am \ -DtagsToInclude="org.apache.gluten.tags.GenerateExample" -Dtest=none -DfailIfNoTests=false -Dexec.skip Review Comment: This doc still uses the system `mvn` binary. Gluten’s contributor docs require running Maven via the `./build/mvn` wrapper (it pins the Maven version and JVM flags), so the command shown here should use `./build/mvn` as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
