zhztheplayer commented on PR #12215: URL: https://github.com/apache/gluten/pull/12215#issuecomment-5437173145
Hi @malinjawi @felipepessoto, thanks for keeping troubleshooting and for iterating the patch. > If nothing reproduces I'll delete the scan-shape detection and this PR becomes just the config + gate coverage, default on. You're right that disabling one scan type is a lot of machinery if the bug is gone. Yes. Regarding the change itself, what concerned me a little bit is the new tag introduced. Generally we need to minimize the number of cross-rule tags to limit the complexity of the query planner. So I would suggest to check whether the conditioned-fallback code can be put in one single place rather than tagging, if this PR needs to be continued further. > On the feature-level switch — agreed it's missing and it's the better knob either way. I'd do it as a follow-up so this PR stays one thing, but if you want it here I'll put it here and drop the scan-specific guard in the same change. Yes, we can open another PR for that. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
