Copilot commented on code in PR #12906: URL: https://github.com/apache/gluten/pull/12906#discussion_r3878475304
########## .github/workflows/delta_spark_ut.yml: ########## @@ -149,8 +149,24 @@ env: DELTA_NUM_SHARDS: '8' # Cancel older `pull_request` and `/delta-test` runs for the same PR. +# +# `issue_comment` fires on every comment posted on an issue or a PR, and +# `github.event.issue.number` is that issue's number, which for a comment on a +# PR is the PR's own number. Such a run would therefore join the PR's group and +# cancel an in-flight suite while `delta-test-requested` below skips it, losing +# the suite and replacing it with nothing. Give only that case a group of its +# own, so every other trigger keeps the exact group name it has today. The +# negated condition is that job's `if` verbatim. Review Comment: PR title/description say this change also "refresh[es] Delta baseline" by deleting 32 entries from `.github/workflows/util/delta-spark-ut/known-failures.txt`, but this PR currently only changes the two workflow YAMLs (no baseline file change). In the current tree, `known-failures.txt` still contains column-mapping entries (e.g. `org.apache.spark.sql.delta.DeltaColumnMappingSuite#...` at lines 87–88 and `org.apache.spark.sql.delta.stats.DataSkippingDeltaV1NameColumnMappingSuite#...` at lines 640+), so the described baseline refresh does not appear to be included. Either add the baseline update to this PR (so Delta shards don’t fail `fail_on_fixed` on PR events) or update the PR title/description to match what’s actually being changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
