Copilot commented on code in PR #12926: URL: https://github.com/apache/gluten/pull/12926#discussion_r3892829621
########## cpp/velox/operators/hashjoin/HashTableBuilder.h: ########## @@ -18,16 +18,17 @@ #pragma once #include <cstdint> -#include <thread> -#include "velox/exec/HashJoinBridge.h" -#include "velox/exec/HashTable.h" -#include "velox/exec/RowContainer.h" -#include "velox/exec/VectorHasher.h" + +#include "velox/exec/JoinTableBuilder.h" Review Comment: HashTableBuilder.h now uses std::unique_ptr/std::shared_ptr/std::vector and std::move but doesn't include the corresponding standard headers, relying on transitive includes from Velox. This makes the header non-self-contained and can break compilation depending on include order. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
