Copilot commented on code in PR #12949:
URL: https://github.com/apache/gluten/pull/12949#discussion_r3905255598
##########
backends-velox/src/test/scala/org/apache/gluten/execution/VeloxOrcDataTypeValidationSuite.scala:
##########
@@ -429,11 +429,7 @@ class VeloxOrcDataTypeValidationSuite extends
VeloxWholeStageTransformerSuite {
" type2 where type1.struct.struct_1 = type2.struct.struct_1") { _ => }
}
- // TODO: Re-enable once Velox implements
HugeintValuesUsingHashTable::mergeWith.
- // The hash join on decimal(38, 18) pushes a hugeint dynamic filter into the
scan
- // (velox#18159), and merging it with the existing IsNotNull filter throws
- // "mergeWith() is not supported".
- ignore("Decimal type") {
+ test("Decimal type") {
Review Comment:
Consider keeping a brief comment referencing the original Velox issue/PR
that motivated the test being ignored (e.g., velox#18159 fixed by velox#18626).
This helps future maintainers quickly triage if the decimal dynamic-filter
behavior regresses.
##########
backends-velox/src/test/scala/org/apache/gluten/execution/VeloxParquetDataTypeValidationSuite.scala:
##########
@@ -430,11 +430,7 @@ class VeloxParquetDataTypeValidationSuite extends
VeloxWholeStageTransformerSuit
" type2 where type1.struct.struct_1 = type2.struct.struct_1") { _ => }
}
- // TODO: Re-enable once Velox implements
HugeintValuesUsingHashTable::mergeWith.
- // The hash join on decimal(38, 18) pushes a hugeint dynamic filter into the
scan
- // (velox#18159), and merging it with the existing IsNotNull filter throws
- // "mergeWith() is not supported".
- ignore("Decimal type") {
+ test("Decimal type") {
Review Comment:
Consider keeping a brief comment referencing the original Velox issue/PR
that motivated the test being ignored (e.g., velox#18159 fixed by velox#18626).
Removing all context makes it harder to understand future regressions if this
test starts failing again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
